New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance client to do reconnect on max connections from server #935
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reasons, the same tests are failing in push/PR.. locally they pass for me, wonder if this is just a coincidence or caused by this PR. Once you make the changes I requested, we will see if the same tests fail again.
@tbeets Discard my comment about same test failing in push/pr since you have only a PR run.. there were 2 tests (but different), one in 1.17 and one in 1.16 (the code coverage run). I am going to recycle to see if those were flappers or not. |
hum... got this test failure again:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The client will attempt reconnect when
maximum connections exceeded
error is sent by server immediately prior to a hard disconnect rather than close without reconnect attempt(s).This is additive to existing re-connection on stale connection from server, auth and perm errors, and read loop errors (such as network disconnect).